[OpenMadrigal-developers] Some patches to Madrigal system

[William Rideout]

Christian,

Thanks for all your suggestions.  Almost all have been added directly to 
Madrigal.  See comments below for any change not used as suggested.


The following diffs are caused by automatic editing of Makefiles, and 
have no effect on Madrigal:

>  
>  # Tcl library directory
> -TCLLIBDIR = /opt/tcl/src/tcl8.0/unix/lib
> +TCLLIBDIR = /usr/local/lib
>  
>  # Tk library directory
> -TKLIBDIR = /opt/tcl/src/tk8.0/unix/lib/
> +TKLIBDIR = /usr/local/lib
>  
>  # Tcl library
> -TCLLIB = tcl8.0
> +TCLLIB = tcl8.4
>  
>  # Tk library
> -TKLIB =  tk8.0
> +TKLIB =  tk8.4
>  
>  # Tcl include directory
> -TCLINCLUDE = /opt/tcl/src/tcl8.0/generic
> +TCLINCLUDE = /usr/local/include
>  
>  # Tk include directory
> -TKINCLUDE = /opt/tcl/src/tk8.0/generic
> +TKINCLUDE = /usr/local/include
>  
>  # Tcl interpreter
> -TCLSH = /opt/tcl/src/tcl8.0/unix/bin/tclsh8.0
> +TCLSH = /usr/local/bin/tclsh

>  
> ==============================
> Prevents segmentation fault when open fails.
> 
> diff -u -r1.10 testMadrec.c
> --- source/madc/madrec/testMadrec.c	26 Dec 2002 16:15:31 -0000	1.10
> +++ source/madc/madrec/testMadrec.c	1 Jul 2003 07:16:27 -0000

I modified this slightly to print a message telling user to install the 
standard test files to make this test succeed.


> 
> ==============================
> Move all javascript to an own "file". This makes the HTML code valid,
> as embedded JavaScript should not contain closing tags. An alternative
> solution would be writeing like document.write("<\/HTML>").
> This solution saves some bandwidth for non-javascript browsers too.

Unfortunately, the javascript code needs to be dynamically generated, 
because in contains pop-up explanations of parameters, which are read 
dynamically from metadata/parcods.tab.  I did change all </ in the 
javascript to <\/.

The page will not work with non-javascript browsers, and would need to 
be significantly modified to support them.

What tool are you using to look for html problems?

> 
> ==============================
> Additionally, I suggest removing bin/ and lib/ directories from CVS as
> they only contains empty README files.

Those directories are used during installation, and this is one of many 
ways to create them.  My only justification for leaving this as is is 
inertia.

> 
> Tell me what you think about this! I will probably spam more patches on
> this list as I proceed with adding some experiment data.

Great work.  I hope you have many more suggestions to add in the future.

Bill



-- 
Bill Rideout
MIT Haystack Observatory
Email: brideout at haystack.mit.edu
Phone: 781 981-5624